Improve Admin CLI #1755
Merged
Improve Admin CLI #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AymericDu
force-pushed
the
improve-admin-cli
branch
5 times, most recently
from
e71a43c to
5398357
Compare
AymericDu
requested review from
fvennetier,
murlock and
kamel-rahim
and removed request for
fvennetier and
murlock
AymericDu
force-pushed
the
improve-admin-cli
branch
3 times, most recently
from
5e071ef to
740c3aa
Compare
murlock
reviewed
May 6, 2019
| yield res | ||
|
|
||
| def check_chunks(self, service, chunks, checker): | ||
| url = self._ensure_http_prefix(service) | ||
| url = 'http://' + service |
There was a problem hiding this comment.
Is it compatible with Service ID ?
There was a problem hiding this comment.
Yes, it's compatible with Service ID.
https://github.com/open-io/oio-sds/blob/master/oio/blob/cache.py#L53
murlock
approved these changes
May 6, 2019
AymericDu
force-pushed
the
improve-admin-cli
branch
from
740c3aa to
8619a5b
Compare
Codecov Report
@@ Coverage Diff @@
## master #1755 +/- ##
==========================================
- Coverage 79.21% 79.15% -0.06%
==========================================
Files 379 379
Lines 69886 69981 +95
Branches 6876 6876
==========================================
+ Hits 55355 55387 +32
- Misses 14330 14393 +63
Partials 201 201
Continue to review full report at Codecov.
|
kamel-rahim
approved these changes
May 6, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Errorsto display the errorsISSUE TYPE
COMPONENT NAME
SDS VERSION